feat: add IP denylist plugin for abuse prevention #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds denylist plugin supporting file-based lists with fsnotify auto-reload and HTTP feeds with periodic refresh. integrates with ipparser (DNS) and acme (HTTP) plugins to block denied IPs. - file sources: local lists with automatic reload on change - feed sources: HTTP lists (Spamhaus DROP, URLhaus) with caching - allow/deny list types: allowlists checked first to bypass denylists - prometheus metrics: blocked requests, list sizes, refresh status - client IP extraction: X-Forwarded-For and RemoteAddr for ACME requests - multiaddr IP checking: validates IPs in libp2p multiaddrs blocked DNS queries return NODATA, blocked ACME requests return HTTP 403.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
==========================================
+ Coverage 64.97% 68.06% +3.09%
==========================================
Files 12 21 +9
Lines 1062 1641 +579
==========================================
+ Hits 690 1117 +427
- Misses 292 403 +111
- Partials 80 121 +41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Note to self: blocked until we figure out why collab cluster lost its dns names. |
Contributor
Author
|
Triage: the cluster issue is specific to the client (investigation tracked in #80, still wip), we can ship this and then have separate release with client fix. |
- TestFeedList304PreservesData: verify data preserved after HTTP 304 - TestFileListDeleteAndRecreate: verify reload after file delete/recreate - TestFileListAtomicSave: verify reload after atomic save (vim-style)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds denylist plugin.
It supports file-based lists with live-reload and HTTP feeds with periodic refresh.
High level
Integrates with
ipparser(DNS returns noA/AAAAfor blocked IPs) andacme(HTTP registration API) plugins to block denied IPs.filesources: local lists with automatic reload on changefeedsources: HTTP lists (Spamhaus DROP, URLhaus) with cachingallow/denylisttype: allowlists checked first to bypass denylistsX-Forwarded-ForandRemoteAddrfor ACME broker requestsDocumentation
See
docs/denylist.mdin this PR.PREVIEW: https://github.com/ipshipyard/p2p-forge/blob/feat/ip-denylist/docs/denylist.md
TLDR
Blocked DNS queries return
NODATA, blocked ACME requests return HTTP 403.This allows us to takedown IP instantly.